Don't detect copies/renames in set-parameters #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The big benefit of this is in a [blobless clone], where it lets you avoid downloading all the blobs (which you shouldn't need just to know _whether_ a file changed). But it's probably a perf win always: it makes `git diff` do a bit less work. And it's probably more correct: for the purposes of whether to run a CI job, a move/copy should count as a modification -- for example one should assume the file must be rebuilt in its new location, the tests for both old and new location should be run, etc. [blobless clone]: https://github.blog/2020-12-21-get-up-to-speed-with-partial-clone-and-shallow-clone/ I tested this by running ```sh git diff --name-only HEAD HEAD~1000 >/dev/null ``` in a blobless clone of a large repo. In that case it logs some messages about the fetches it's doing. (And empirically in our actual CI pipeline it has occasionally failed, if the blob fetch fails due to network flakes.) With the new flags, it does not, and returns much more quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big benefit of this is in a blobless clone, where it lets you avoid downloading all the blobs (which you shouldn't need just to know whether a file changed). But it's probably a perf win always: it makes
git diffdo a bit less work. And it's probably more correct: for the purposes of whether to run a CI job, a move/copy should count as a modification -- for example one should assume the file must be rebuilt in its new location, the tests for both old and new location should be run, etc.I tested this by running
git diff --name-only HEAD HEAD~1000 >/dev/nullin a blobless clone of a large repo. In that case it logs some messages about the fetches it's doing. (And empirically in our actual CI pipeline it has occasionally failed, if the blob fetch fails due to network flakes.) With the new flags, it does not, and returns much more quickly.